[WIP] Predownload wheel sources #4971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@publicarray I have no clue if this will work as it requires |
|
@publicarray I've looked at the logs and it didn't ran the github-action part, neither I believe the docker was update (but ain't sure). |
|
The action did run but I think an if/else might be the wrong way around. It didn't actually build however it did login and out of the docker repository |
|
The docker build should only be uploaded when it's on the master branch. Doing this in a pr only serves to know if the build will pass or fail |
miigotu
reviewed
Nov 17, 2021
th0ma7
force-pushed
the
predownload-wheels
branch
from
7b6bd12 to
b07d980
Compare
publicarray
requested changes
Nov 20, 2021
publicarray
reviewed
Nov 21, 2021
spk/beets/Makefile
Outdated
| SPK_REV = 6 | ||
| SPK_REV = 7 |
There was a problem hiding this comment.
Just a reminder to undo these changes before merging
th0ma7
force-pushed
the
predownload-wheels
branch
from
cae8607 to
80998df
Compare
hgy59
reviewed
Dec 19, 2021
This was referenced Dec 19, 2021
th0ma7
force-pushed
the
predownload-wheels
branch
from
9681e98 to
d041067
Compare
3 tasks
th0ma7
force-pushed
the
predownload-wheels
branch
from
6799801 to
0bdfb50
Compare
th0ma7
force-pushed
the
predownload-wheels
branch
from
0bdfb50 to
5c17b89
Compare
10 tasks
th0ma7
force-pushed
the
predownload-wheels
branch
from
5add722 to
7553a4d
Compare
93 tasks
|
Superseeded by #5820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: In order to eliminate
connection timeouttry to pre-download wheels at the start of the build process so all arch builds can then refer to it afterwards.Linked issues: #4951 and #4968
Checklist
all-supportedcompleted successfully