Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be user #4355

Closed
wants to merge 26 commits into from
Closed

Should be user #4355

wants to merge 26 commits into from

Conversation

cskiwi
Copy link
Contributor

@cskiwi cskiwi commented Jan 2, 2021

Motivation: As of the documentation this value should be a user.
https://global.download.synology.com/download/Document/Software/DeveloperGuide/Firmware/DSM/All/enu/Synology_DiskStation_Administration_CLI_Guide.pdf (page 8)

synoshare {--add} sharename share_desc share_path user_list_na user_list_rw user_list_ro share_browsable adv_privilege

note: This could be $EFF_USER. Not sure.

publicarray and others added 23 commits January 2, 2021 20:33
  (synouser, synogroup, synoshare)
* remove tool that fail to modify permissions (synoacltool)
* remove tool that fail to apply configuration (servicetool)

servicetool, synouser, synogroup and synoshare have alternative
 ways to do the same thing using resource configuration
- change icon size from 72x72 to 64x64 for DSM 7
fixes missing log entries on reinstall
TODO add moreutils package, use sponge to prevent overriding file with 0 content
- 1<> $@
+ | sponge $@
…e user can create, they are invisible in the UI an are only useful to access another packages permissions (ffmpeg comes to mind)

For DSM7 I recommend setting permissions for individual packages (System Internal User)
or use the shared folder resource worker to add permissions. We can ask the user from the wizard the folder name

"join-groupname": "http" is for system groups, mainly for the web service ("root" don't work but "system" does)
Remove some more statements that modify files in places where we don't have permissions or is just unnecessary in DSM7
Comment on lines 4 to 9
_Package Name:_
_Package Version:_

_NAS Model:_
_NAS Architecture:_
_DSM version:_
_NAS Model:_
_NAS Architecture:_
_DSM version:_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not remove trailing spaces in this file.
If issue form is filled without space after _ the italic font of the subjects does not work.

@hgy59
Copy link
Contributor

hgy59 commented Jan 2, 2021

@cskiwi thanks for contributing to this repository.
For DSM7 related contributions you must checkout and use the dsm7 branch in your repository.
We do not accept PRs for dsm 7 on master branch by now.
All about the current state of dsm7 support is discussed in #4215.

If the user permission fix is related to dsm 6 and older too, please create a dedicated PR for this.

@hgy59 hgy59 closed this Jan 2, 2021
@publicarray
Copy link
Member

Ah part of it is my mistake, I rebased my dsm7 branch to get the latest changes from master, but I don't know how these commits have been added here?

@publicarray
Copy link
Member

If the user permission fix is related to dsm 6 and older too, please create a dedicated PR for this.

Yea that is what I meant in publicarray#25 (comment)

@cskiwi cskiwi mentioned this pull request Jan 3, 2021
@cskiwi
Copy link
Contributor Author

cskiwi commented Jan 3, 2021

Something went wrong with my master branch that's why it included the DSM7 stuff.
I'm trying again in: #4357

sorry for the discomfort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants