-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should be user #4355
Should be user #4355
Conversation
(synouser, synogroup, synoshare) * remove tool that fail to modify permissions (synoacltool) * remove tool that fail to apply configuration (servicetool) servicetool, synouser, synogroup and synoshare have alternative ways to do the same thing using resource configuration
- change icon size from 72x72 to 64x64 for DSM 7
fixes missing log entries on reinstall
TODO add moreutils package, use sponge to prevent overriding file with 0 content - 1<> $@ + | sponge $@
…e user can create, they are invisible in the UI an are only useful to access another packages permissions (ffmpeg comes to mind) For DSM7 I recommend setting permissions for individual packages (System Internal User) or use the shared folder resource worker to add permissions. We can ask the user from the wizard the folder name "join-groupname": "http" is for system groups, mainly for the web service ("root" don't work but "system" does)
Remove some more statements that modify files in places where we don't have permissions or is just unnecessary in DSM7
.github/ISSUE_TEMPLATE.md
Outdated
_Package Name:_ | ||
_Package Version:_ | ||
|
||
_NAS Model:_ | ||
_NAS Architecture:_ | ||
_DSM version:_ | ||
_NAS Model:_ | ||
_NAS Architecture:_ | ||
_DSM version:_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not remove trailing spaces in this file.
If issue form is filled without space after _ the italic font of the subjects does not work.
@cskiwi thanks for contributing to this repository. If the user permission fix is related to dsm 6 and older too, please create a dedicated PR for this. |
Ah part of it is my mistake, I rebased my dsm7 branch to get the latest changes from master, but I don't know how these commits have been added here? |
Yea that is what I meant in publicarray#25 (comment) |
Something went wrong with my master branch that's why it included the DSM7 stuff. sorry for the discomfort |
Motivation: As of the documentation this value should be a user.
https://global.download.synology.com/download/Document/Software/DeveloperGuide/Firmware/DSM/All/enu/Synology_DiskStation_Administration_CLI_Guide.pdf (page 8)
synoshare {--add} sharename share_desc share_path user_list_na user_list_rw user_list_ro share_browsable adv_privilege
note: This could be
$EFF_USER
. Not sure.