Add 'file' and 'rnm' to Synocli-File #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- redesign cross/ncursesw to make independent of cross/ncurses - create links for specific hashes of rhash - add 'file' and 'rnm' to diyspk - remove links on uninstall only if still linking to this package - add creation of c++ library to cross/gmp
|
Is "file" required for "rnm" ? Because "file" is already available in the synogear diagnostic tool (total of 127 commands available) |
ymartin59
approved these changes
Sep 21, 2019
cross/mc/PLIST
Outdated
| @@ -2,7 +2,7 @@ bin:bin/mc | |||
| bin:bin/mcdiff | |||
| bin:bin/mcedit | |||
| bin:bin/mcview | |||
| rsc:etc/mc | |||
| etc:etc/mc | |||
There was a problem hiding this comment.
Please let "rsc" here - "etc" means nothing according to https://github.com/SynoCommunity/spksrc/wiki/PLIST-files
| @@ -1,12 +1,2 @@ | |||
| bin:bin/ed2k-link | |||
There was a problem hiding this comment.
Sure to remove other executables?
There was a problem hiding this comment.
yes, these are only links to bin/rhash and are created as links upon installation again.
|
I am including |
AlexPresso
pushed a commit
to AlexPresso/spksrc
that referenced
this pull request
Jan 30, 2025
* Add 'file' and 'rnm' to Synocli-File - redesign cross/ncursesw to make independent of cross/ncurses - create links for specific hashes of rhash - add 'file' and 'rnm' to diyspk - remove links on uninstall only if still linking to this package - add creation of c++ library to cross/gmp * incorporate code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
rnmis a rename tool without dependency of perl or pythonLinked issues: #3250, #2944
Checklist
all-supportedcompleted successfully@AdithyaBenny can you verify whether rnm is worthful replacement for rename?
@fredrike can you confirm that creating links for special hashes is what it's ment for?