Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 4.8.22 #3611

Closed
wants to merge 12 commits into from
Closed

Update to 4.8.22 #3611

wants to merge 12 commits into from

Conversation

4sag
Copy link

@4sag 4sag commented Feb 4, 2019

Motivation: Explain here what the reason for the pull request is.
Linked issues: Optionally, add links to existing issues or other PR's

Checklist

  • [] Build rule all-supported completed successfully
  • [] Package upgrade completed successfully
  • [] New installation of package completed successfully

@4sag
Copy link
Author

4sag commented Feb 4, 2019

Update to 4.8.22

@4sag
Copy link
Author

4sag commented Feb 4, 2019

update nano, mc, adminer.

@m4tt075
Copy link
Contributor

m4tt075 commented Feb 4, 2019

@4sag I appreciate your contributions, but this is difficult to follow and to handle. It is unclear which compilations you have tried and which pacakges you have tested. In addition, I'm currently integrating mc and nano into our SynoCLI-filepackage (see PR #3250 for details), so the corresponding spks will go away anyways.

Could you please do the following:

  1. Close your PRs again.
  2. Create a new branch, where you just update adminer (this is not being worked on to my knowledge)
  3. Conduct the requested tests, in terms of cross-compiling for all platforms
  4. Conduct a proper test whether the resulting package works, when it is installed cleanly and when you upgrade from an older version
  5. Create a proper PR with description, where you detail all the information requested in the PR template?

@ymartin59
Copy link
Contributor

@4sag I propose you to create a dedicated PR for "adminer" update. Thank you in advance for your help. Regards. Yves

@ymartin59 ymartin59 closed this Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants