Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rsync version 3.1.3 to synocli-net #3581

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

fredrike
Copy link
Contributor

Motivation: Synologys built-in rsync is old and have features that prohibits receiving data over ssh.

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@acolomb
Copy link
Contributor

acolomb commented Jan 16, 2019

Will this work when connecting via SSH as a non-admin user and specifying the rsync binary path?

Synology's rsync can work over SSH with regular user login, if the rsync service is enabled through Control Panel. Though I have no clue what magic allows that despite regular SSH (shell) access being restricted to admin users. Some trickery with AppArmor I suppose...

@ymartin59
Copy link
Contributor

I am just wondering if synocli-net is the right place... What about synocli-files #3250 ?

@fredrike
Copy link
Contributor Author

Rsync is typically used to move files between computers but if you suggest me to move it I'll do that.

@ymartin59
Copy link
Contributor

I made my mind. It is OK for me in synocli-net

@ymartin59
Copy link
Contributor

Waiting for Mosh fix to merge and publish: #3582 and #3583

@acolomb
Copy link
Contributor

acolomb commented Jan 19, 2019

So what about my comment? How does it interact / possibly interfere with Synology's built-in rsync?

@fredrike
Copy link
Contributor Author

@acolomb I'm not sure how it will work. You must have ssh working for your user but you should not need to have configured rsync the Synology way.
I'll get back to you once I've tested it and know exactly how it will work.

@ymartin59
Copy link
Contributor

I will test and check how it works. Probably user has to prepend its PATH variable in $HOME/.bashrc so that package binary has precedence over system version. By the way, should be documented in synocli-net package FAQ

@fredrike
Copy link
Contributor Author

fredrike commented Jan 21, 2019

My idea is to use --rsync-path= to the synocli-net version when sending files to the Synology (https://www.computerhope.com/unix/rsync.htm).

And is not the binaries symlinked to the path? Perhaps not the right order. Should we call this rsync-gnu then (as opposed to the native Synology patched version of rsync).

The whole idea with this package is to support newer features and also not be forced to configure unix services the Synology way.

@ymartin59
Copy link
Contributor

Thanks for hint. I will test and document relevant options.

@acolomb
Copy link
Contributor

acolomb commented Jan 22, 2019

I would also think the --rsync-path option would be the right way to use it. I'm not sure whether rsync even invokes a shell over the remote SSH connection, so setting PATH in .bashrc will not even work. Plus Synology forces the users' shell to /bin/sh which is a symlink to bash but causes it to not evaluate the bashrc file.

So installing as rsync-gnu or even rsync-community sounds like a good idea. A symlink into /usr/bin is optional IMHO.

My background for the non-admin SSH question is that I gladly discovered Synology allows them to run rsync remotely, but prevents shell access. Whatever mechanism is used for this, it is enabled with the rsync service in Control Panel. I would try to replicate that permission setting for your rsync-gnu binary. And what I'm after is actually producing a package for Unison that also works for non-admin users over SSH. Though it is still a lot of work and my time is quite limited currently.

@ymartin59 ymartin59 merged commit e94549f into SynoCommunity:master Dec 5, 2019
@Erwane
Copy link

Erwane commented Dec 23, 2019

Hi.

Do you known when rsync will be added and pushed toSynoCommunity please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants