Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package synocli-net #3544

Merged
merged 8 commits into from
Jan 3, 2019
Merged

Package synocli-net #3544

merged 8 commits into from
Jan 3, 2019

Conversation

ymartin59
Copy link
Contributor

@ymartin59 ymartin59 commented Dec 9, 2018 •
edited
Loading

Linked issues: #3254 #3267 #3526 #3489

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • [N/A] New installation of package completed successfully

@ymartin59 ymartin59 self-assigned this Dec 9, 2018
This was referenced Dec 9, 2018
Closed
Closed
This was referenced Dec 20, 2018
Closed
Closed
@ymartin59 ymartin59 mentioned this pull request Dec 27, 2018
Merged
1 task
@m4tt075
Copy link
Contributor

m4tt075 commented Dec 30, 2018

@ymartin59 Very nice implementation! Great stuff, including @publicarray 's icon! 👍
Only part I don't understand is: Why do you keep the "spk/tmux/*" files, allowing separate installation of the tmux package AND include it in the synocli-net bundle? I would have guessed it to be one "xor" the other. Is there a particular reason for this?

@ymartin59
Copy link
Contributor Author

@m4tt075 You're right - I have decided to remove "spk/mosh" from proposed PR but kept "spk/tmux" - in case anyone may want to build its own and so get a lighter package that synocli-net which is already 12 MiB heavy.
Another idea I have is to replace "spk/tmux" soon to publish a wizard only package and dependency to synocli-net to notify users about replacement.

@m4tt075
Copy link
Contributor

m4tt075 commented Dec 30, 2018

Cool!

@ymartin59 ymartin59 merged commit 7ffaad9 into SynoCommunity:master Jan 3, 2019
@nbarrientos
Copy link
Contributor

Sorry for the noise, but have you by any chance removed tmux standalone in view of adding this bundle? Can't find it now in the list of available packages to install on my DS418 (rtd1296) running 6.2 latest. Thanks :)

@nbarrientos
Copy link
Contributor

Sorry, didn't have beta packages enabled.

@ymartin59 ymartin59 mentioned this pull request Jan 11, 2019
Closed
@ymartin59 ymartin59 deleted the 3254-synocli-net branch January 21, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ymartin59 ymartin59

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ymartin59 @m4tt075 @nbarrientos @hgy59 @publicarray @obourdon @fredrike