-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ffmpeg compilation for rtd1296 architecture #3119
Conversation
@ymartin59 Gave it another try and got it working, but please review... |
cross/ffmpeg/Makefile
Outdated
@@ -42,6 +42,10 @@ ifeq ($(findstring $(ARCH),$(ARM7_ARCHES)),$(ARCH)) | |||
CONFIGURE_ARGS += --arch=arm --disable-neon --disable-armv6 --disable-armv6t2 --disable-vfp --disable-armv5te --disable-yasm --disable-asm | |||
endif | |||
|
|||
ifeq ($(findstring $(ARCH),$(ARM8_ARCHES)),$(ARCH)) | |||
CONFIGURE_ARGS += --arch=arm64 --disable-neon --disable-yasm --disable-asm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the disable-nepn
required? Because Neon can make a huge performance impact, as far as I know from general programming. It's like SSE2/3 of ARM, so it seems very important on low power devices and I'm pretty sure this platform should support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://developer.arm.com/technologies/neon we should consider NEON is available for both ARMv7 and ARMv8.
I propose to give a try to remove --disable-neon
flag for these two architecture.
May you please build for rtd1297
this PR and submit to requester for "beta" testing ?
I have built and submitted package for testing |
Yes, makes sense. Just pushed the changes. Building here. |
Hello, i am betatesting your package :) I just installed it on my DS216play which is packed with an rtd1296 and video's with DTS seems to be working. Amazing work 👍 |
@m4tt075 any idea why all the |
@Safihre Yes, found it. Working on it. Pushing update soon... |
Next build attempts here |
Already one user reported |
I have to review my pending branches with some updates related to |
OK, all 6.1 builds are green. Test packages are here. @ymartin59 Feel free to cherry-pick my commits into a bigger |
@m4tt075 Thanks a lot. That is my idea. I take opportunity to update as much as possible because of publication process cost... |
@ymartin59 why not use the (Docker based) Travis image to do the publishing? You can add your SynoCommunity login details as a Travis secret/encrypted environment variable. |
Replaced by #3136. Unfortunately no longer builds for DSM 5.2 |
Motivation:
ffmpeg
compilation has been broken forrtd1296
platform and all packages depending onffmpeg
. This PR fixes those issue.x264
has been upgraded to the most recent stable snapshot in the process as well. Untested so far, as I do not own artd1296
device.Checklist
rtd1296
architectureall-supported
completed successfully