Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollolake update #3088

Closed
wants to merge 7 commits into from
Closed

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Jan 9, 2018

Motivation: I have a DS918+ and with the initial spksrc copy 31 of 110 packages failed to build. Apart of apollolake some fixes for hi3535 (armv7) and rtd1296 (aarch64) are included in this PR.
Linked issues: partial fixes for #3031, #2886

Packages with newly fixed build for apollolake arch

  • debian-chroot
  • gentoo-chroot
  • lirc

other packages will follow...

@Safihre
Copy link
Contributor

Safihre commented Jan 10, 2018

👍
Seems in these packages it's better to use the ARM7_ARCHES/ARM8_ARCHES/etc: https://github.com/SynoCommunity/spksrc/blob/master/mk/spksrc.common.mk#L36-L38
Should probably have been done long ago already!

@Safihre
Copy link
Contributor

Safihre commented Jan 13, 2018

@hgy59 could you try using the general variables instead of the specific archs?
For this you might need to move the include xxx.mk above the if statements. Otherwise the variables are not known.
Had to do similar for syncthing: https://github.com/SynoCommunity/spksrc/pull/3094/files

@hgy59
Copy link
Contributor Author

hgy59 commented Jan 14, 2018

Replaced by PR #3099

@hgy59 hgy59 closed this Jan 14, 2018
@hgy59 hgy59 deleted the apollolake_update branch January 30, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants