Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package 'jdupes' #3030

Closed
wants to merge 1 commit into from
Closed

Add package 'jdupes' #3030

wants to merge 1 commit into from

Conversation

jbruchon
Copy link
Contributor

@jbruchon jbruchon commented Dec 5, 2017

Motivation: Motivation: Add a package for 'jdupes' as requested on Reddit.
Linked issues: N/A

Checklist

Builds with make all-supported but I do not have a Synology NAS to install them onto.

@Zaxim
Copy link

Zaxim commented Mar 27, 2018

Is this request going to be merged soon? I'd love to have a jdupes package built in, as running it over a mounted share is agonizingly slow.

@jbruchon
Copy link
Contributor Author

It's been nearly a year. Is this ever going to be merged?

@mneuron
Copy link

mneuron commented Jan 10, 2019

I crosscompiled the files on my DS918+ and it works flawless.
I recommend a merge!

@trlafleur
Copy link

would love to see this as a built-in function....

@jbruchon
Copy link
Contributor Author

I'm disappointed that I put the effort into doing this and it still isn't merged, especially with users actively calling for a merge, an approval from what I assume is a project contributor, and a report of a confirmed working build on real hardware. I would greatly appreciate either a hasty merge or a clear explanation of the reason that the merge has been held back for 13 months.

@m4tt075
Copy link
Contributor

m4tt075 commented Jan 24, 2019

Understood. The explanation is very simple: Lack of "management" resources. There is currently only one person (@ymartin59), who ensures quality, oversees merging and publications and his resources are limited too.

What I understand is, is that jdupes should be included as one of the tools in the SynoCli Files package. Up until recently, there was no proof of concept for those kind of SynoCli packages. However, the first one, SynoCli Net, has recently been finalized and merged. I'm willing to look into it and see whether I can draft the SynoCli Files one. @ymartin59 still would have to merge it eventually, but it might help getting the ball rolling...

@m4tt075 m4tt075 mentioned this pull request Jan 26, 2019
3 tasks
@m4tt075
Copy link
Contributor

m4tt075 commented Jan 27, 2019

@jbruchon OK. Here we go. Many thanks for your contribution! I'm looking into merging your work as part of the SynoCLI-file package. If you are still interested, please feel free to track any progress in issue #3250 and PR #3598.

For everyone, test-builds of the SynCLI-file package for all currently supported DSM5.2, 6.1 and 6.2 platforms are available here: https://github.com/m4tt075/spksrc/releases/tag/synoclifile-2
Please report any issues in #3250, not here.

@ymartin59 ymartin59 closed this Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants