Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less package -- Initial version 487. #2818

Closed
wants to merge 1 commit into from

Conversation

mthibaut
Copy link

Motivation: Add less pager to synology
Linked issues: N/A

Checklist

  • [] Build rule all-supported completed successfully
    $ ls ../../packages/
    less_88f6281-5.2_487-1.spk less_comcerto2k-5.2_487-1.spk
    less_alpine-5.2_487-1.spk less_evansport-5.2_487-1.spk
    less_armada370-5.2_487-1.spk less_monaco-5.2_487-1.spk
    less_armada375-5.2_487-1.spk less_ppc853x-5.2_487-1.spk
    less_armada38x-5.2_487-1.spk less_qoriq-5.2_487-1.spk
    less_armadaxp-5.2_487-1.spk less_x64-5.2_487-1.spk

  • [] Package upgrade completed successfully
    N/A

  • [] New installation of package completed successfully
    Yes on my Syno

@ymartin59
Copy link
Contributor

From my point of view, a "GNU" icon would be more relevant than Tux

LICENSE = GPLv2

INSTALLER_SCRIPT = src/installer.sh
SSS_SCRIPT = src/dsm-control.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably there is no need to refer such a "no-op" script. I have not tested myself, but I guess removing SSS_SCRIPT still produces a working package

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified to work without the SSS_SCRIPT setting (and the dsm-control.sh script) on DSM 6.1 / rtd1296.
However, I needed to add cross/termcap to DEPENDS in cross/less/Makefile.

@ymartin59
Copy link
Contributor

In fact, there is a old PR pending for less too: #2075. Refer to #2261 issue.

@m4tt075 m4tt075 mentioned this pull request Jan 26, 2019
3 tasks
@m4tt075
Copy link
Contributor

m4tt075 commented Jan 27, 2019

@mthibaut Well, it has been some time. Nevertheless, many thanks for your contribution! As pointed out, there has been an earlier PR #2075, proposing to integrate less into spksrc. I'm looking into merging it as part of a bigger SynoCLI-file package. If you are still interested, please feel free to track any progress in issue #3250 and PR #3598.

For everyone, test-builds of the SynCLI-file package for all currently supported DSM5.2, 6.1 and 6.2 platforms are available here: https://github.com/m4tt075/spksrc/releases/tag/synoclifile-2
Please report any issues in #3250, not here.

@m4tt075
Copy link
Contributor

m4tt075 commented Jan 27, 2019

Closing, as duplicate of #2075.

@m4tt075 m4tt075 closed this Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants