Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change prefix from PET to STIR for DataContainer #1126

Closed
KrisThielemans opened this issue Jul 6, 2022 · 0 comments · Fixed by #1146
Closed

Change prefix from PET to STIR for DataContainer #1126

KrisThielemans opened this issue Jul 6, 2022 · 0 comments · Fixed by #1146
Assignees
@evgueni-ovtchinnikov
Milestone
v3.6

Comments

@KrisThielemans
Copy link
Member

As STIR data-containers can handle PET and SPECT, we should not include PET in their name.

See also #1078 (comment)_
@KrisThielemans KrisThielemans added this to the v4.0 milestone Jul 6, 2022
evgueni-ovtchinnikov added a commit that referenced this issue Nov 15, 2022
@evgueni-ovtchinnikov
PETAcquisitionData -> STIRAcquisitionData, fixes #1126
2daf037
Merged
6 tasks
@evgueni-ovtchinnikov evgueni-ovtchinnikov modified the milestones: v4.0, v3.4 Nov 15, 2022
evgueni-ovtchinnikov added a commit that referenced this issue Nov 17, 2022
@evgueni-ovtchinnikov
Change prefix from PETAcquisitionData to STIRAcquisitionData. (#1146)
e043a5a 
* PETAcquisitionData -> STIRAcquisitionData, fixes #1126

* backward compatibility typedefs only used if SIRF version < 4.0.0

* trying to fix build error (no version.h)

* [ci skip] updated CHANGES.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evgueni-ovtchinnikov evgueni-ovtchinnikov

Labels
None yet
Projects
None yet
Milestone
v3.6
Development

Successfully merging a pull request may close this issue.

Change prefix from PETAcquisitionData to STIRAcquisitionData. SyneRBI/SIRF
2 participants
@KrisThielemans @evgueni-ovtchinnikov