Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(base58,core): Update base58 dependency, remove crypto/base58 #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

InKryption
Copy link
Contributor

Refactor & enhance all dependent code, and make adjacent refactors

@InKryption InKryption self-assigned this Jan 31, 2025
@InKryption InKryption requested review from yewman and dnut January 31, 2025 18:12
0xNineteen
0xNineteen previously approved these changes Jan 31, 2025
Copy link
Contributor

@0xNineteen 0xNineteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm :shipit:

0xNineteen
0xNineteen previously approved these changes Feb 3, 2025
@InKryption InKryption disabled auto-merge February 3, 2025 19:13
@InKryption InKryption added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants