fix(cmd): DNS improvements #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InKryption
force-pushed
the
ink/dns-improvement
branch
from
7c21d0e to
f576f5e
Compare
|
Merging this would make merging #166 easier, since it gives us one less dependency to update. |
0xNineteen
requested changes
Jun 7, 2024
InKryption
force-pushed
the
ink/dns-improvement
branch
from
44ec419 to
00d76a0
Compare
InKryption
force-pushed
the
ink/dns-improvement
branch
2 times, most recently
from
7430655 to
f8e0fbd
Compare
Use the stdlib's `std.net.getAddressList` instead of zigdig's. The latter appears to not work correctly in a Spanish laptop, whilst the former does. Also make it deduplicate identical entrypoints.
now that we use `std.net.getAddressList`, we no longer need zigdig, since all we were using it for was the high-level DNS resolution.
Just use a normal hash set duplicating the entrypoints in the arraylist, and eschew the custom entrypoint list formatting.
InKryption
force-pushed
the
ink/dns-improvement
branch
from
f8e0fbd to
1a5116d
Compare
0xNineteen
approved these changes
Jun 10, 2024
|
looks great - great to remove a dep 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't identify any issues with just using zig stdlib's version of
getAddressList, it appears to work better internationally, and using it means we have one less dependency (we get rid of zigdig).I also took the time to replace the string buliding with a formatting function for the log, and used an adapted ArrayHashMap(void, void) hash map to deduplicate entrypoints (on that note, should we issue a warning for duplicate domains or anything like that?).