Add color correction on loopback for img2img (add new dependency) #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm this does fix the issue of long loopbacks eventually turning into a strong magenta mush |
1 task
hlky
added a commit
that referenced
this pull request
Sep 6, 2022
hlky
added a commit
that referenced
this pull request
Sep 7, 2022
* #715 #699 #698 #663 #625 #617 #611 #604 (#716) * Update README.md * Add sampler name to metadata (#695) Co-authored-by: EliEron <[email protected]> * old-dev-merge Co-authored-by: EliEron <[email protected]> Co-authored-by: EliEron <[email protected]> * img2img-fix (#717) * Revert "img2img-fix (#717)" This reverts commit 70d4b1c. * img2img fixes * Revert "img2img fixes" This reverts commit e66eddc. * Revert "Revert "img2img-fix (#717)"" This reverts commit bf08b61. * img2img fixed * feat: bring back Crop mode, formatting Co-authored-by: EliEron <[email protected]> Co-authored-by: EliEron <[email protected]> Co-authored-by: Thomas Mello <[email protected]>
|
Thanks for this. FYI I based the following PR to @AUTOMATIC1111 's repo on your change: AUTOMATIC1111/stable-diffusion-webui#135 |
TinyBeeman
pushed a commit
to TinyBeeman/stable-diffusion-webui-tiny
that referenced
this pull request
Sep 8, 2022
* Sygil-Dev#715 Sygil-Dev#699 Sygil-Dev#698 Sygil-Dev#663 Sygil-Dev#625 Sygil-Dev#617 Sygil-Dev#611 Sygil-Dev#604 (Sygil-Dev#716) * Update README.md * Add sampler name to metadata (Sygil-Dev#695) Co-authored-by: EliEron <[email protected]> * old-dev-merge Co-authored-by: EliEron <[email protected]> Co-authored-by: EliEron <[email protected]> * img2img-fix (Sygil-Dev#717) * Revert "img2img-fix (Sygil-Dev#717)" This reverts commit 70d4b1c. * img2img fixes * Revert "img2img fixes" This reverts commit e66eddc. * Revert "Revert "img2img-fix (Sygil-Dev#717)"" This reverts commit bf08b61. * img2img fixed * feat: bring back Crop mode, formatting Co-authored-by: EliEron <[email protected]> Co-authored-by: EliEron <[email protected]> Co-authored-by: Thomas Mello <[email protected]>
hlky
added a commit
that referenced
this pull request
Sep 8, 2022
* #715 #699 #698 #663 #625 #617 #611 #604 (#716) * Update README.md * Add sampler name to metadata (#695) Co-authored-by: EliEron <[email protected]> * old-dev-merge Co-authored-by: EliEron <[email protected]> Co-authored-by: EliEron <[email protected]> * img2img-fix (#717) * Revert "img2img-fix (#717)" This reverts commit 70d4b1c. * img2img fixes * Revert "img2img fixes" This reverts commit e66eddc. * Revert "Revert "img2img-fix (#717)"" This reverts commit bf08b61. * img2img fixed * - Removed duplicated calls to save_sample. - Change variables and arguments to be more self-explanatory and easier to understand what they do. * Moved streamlit files to their proper location, before they were incorrectly added to the repository root folder. * Added retry dependency for the streamlit version. * Added .cmd file for easy running and updating the streamlit version of the UI. * Removed duplicated entry for streamlit on the environment.yaml file. * Removed some unnecessary lines from the the webui_streamlit.cmd file. * add gfpgan folder to gitignore, auto gen by imglab * added placeholder text similar to gradio * added auto conversion for 4 channel PNG to RGB * fix: regex escape characters * Update Readme links to sd-webui when appropriate (#781) * Update link to sd-webui when appropriate * added LDSR instruction per devilismyfriend guide * fix: stack overflow during recursion call (#784) * Added option to set default sampler name from config file, will be useful for those wanting to change the default sampler and have it persist even when closing the UI and opening it again. * Added try and except block to handle basic errors like StopException which is raised by streamlit when you hit the stop button and KeyError which happens also when stopping the generation because it tries to check the model at the end which is not loaded at that time, this can be ignored and so thats the reason for the exception. * separate css to external file * Added "git pull" and "git stash" to the commands run by the cmd scripts when launching the UI, this should make it so people who use it can automatically update the code from the repo and be up to date without manually using those commands everytime. * resolve conflict with master Co-authored-by: EliEron <[email protected]> Co-authored-by: EliEron <[email protected]> Co-authored-by: ZeroCool <[email protected]> Co-authored-by: ZeroCool940711 <[email protected]> Co-authored-by: Hafiidz <[email protected]> Co-authored-by: Thomas Mello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs scikit-image to work, update environment.yaml in the main repo
Images are color corrected before being fed back to the loop.
The original implementation by @Pyr-000
Should close #457 if merged with master