launcher: Fix batch file (#920, #605) #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prsyahmi
commented
Sep 13, 2022
•
prsyahmi
commented
- Allow reading environment.yaml file in either LF or CRLF ([Bug]: .cmd don't launch #920)
- Only update environment if environment.yaml changes
- Remove custom_conda_path to discourage changing source file
- Fix unable to launch webui due to frontend module missing ([Bug]: Problems with the launch "(Updated 8/29) Alternate Prepack Installer" #605)
hlky
approved these changes
Sep 13, 2022
prsyahmi
changed the title
prsyahmi
commented
Sep 13, 2022
webui-streamlit.cmd
Outdated
| call "%v_conda_path%\Scripts\activate.bat" | ||
|
|
||
| for /f "delims=" %%a in ('git log -1 --format^="%%H" -- environment.yaml') DO set v_cur_hash=%%a | ||
| set /p "v_last_hash="<"z_version_env.tmp" 1>NUL 2>&1 |
There was a problem hiding this comment.
I accidentally left some test error output redirection here which isn't working. So going to remove it
- Allow reading environment.yaml file in either LF or CRLF - Only update environment if environment.yaml changes - Remove custom_conda_path to discourage changing source file - Fix unable to launch webui due to frontend module missing (Sygil-Dev#605)
ZeroCool940711
approved these changes
Sep 13, 2022
codedealer
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.