support xcompat #53
Merged
support xcompat #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add materials for crafting tools and sounds. - optionally depend on default and xcompat in later phase we can drop dependancy on default and make xcompat a hard dependancy (still in consideration)
SwissalpS
referenced
this pull request
in Sokomine/replacer
Jul 21, 2024
there is a replacer.yes() function (not used by replacer) so makes sense to offer api for no() -> false (used by games not providing creative global).
not strictly part of xcompat support, just couldn't help myself. log messages aren't translated, so no need to rework locale files for this.
limited extent
mainly for mineclonia family that uses many multiline descriptions. Only shows one more line nicely, some items ave three or even more though.
- persistancy -> persistency - acheivment -> achievement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
become independant of base game and thus support more games.
in later phase we can drop dependancy on default and make xcompat a hard dependancy (still in consideration)
phase 2:
focus on inspector
phase 3:
test and focus on replacer
- [ ] phase 4:- add more compat code for mods of other games(We can do that in other PRs, as this would take too long and hold up the essential benifit of this PR)