Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatability w/ WIP moreblocks/stairsplus #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fluxionary
Copy link

update for compatibility with minetest-mods/moreblocks#191. without this update, things will still work, but stairsplus ("circular saw") integration won't register.

@SwissalpS
Copy link
Owner

@fluxionary what's the state of this? I see that the PR#191 has been closed. Did the part that concerns this mod get merged in another PR or did you fork?

Guess I could add this anyway to support your fork, but I'd like to make sure first the changes you PRed here are still valid.

@fluxionary
Copy link
Author

fluxionary commented Mar 22, 2024

@fluxionary what's the state of this? I see that the PR#191 has been closed. Did the part that concerns this mod get merged in another PR or did you fork?

Guess I could add this anyway to support your fork, but I'd like to make sure first the changes you PRed here are still valid.

I made a hard fork, though a couple people are still petitioning Calinou to accept my PR. the hard fork is being used on at least a couple servers, and I'm supporting it.

@SwissalpS
Copy link
Owner

@fluxionary Since minetest-mods still hasn't merged your fork, I've finally added support for it.
Sorry I didn't use your approach, I was weighing back and forth for some time and decided not to split moreblocks compat into two files.

If you have a moment to scan this PR or maybe even test it with your fork that would be much apreciated.
#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants