Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): fix overwriting dataset tags #3497

Merged
merged 8 commits into from
Jul 7, 2023
Merged

fix(cli): fix overwriting dataset tags #3497

merged 8 commits into from
Jul 7, 2023

Conversation

Panaetius
Copy link
Member

closes #3463

@Panaetius Panaetius requested a review from a team as a code owner June 2, 2023 06:59
@coveralls
Copy link
Collaborator

coveralls commented Jun 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5483939270

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall First build on fic/3463-overwrite-tag at 85.782%
Totals Coverage Status
Change from base Build 5483933201: 85.8%
Covered Lines: 25793
Relevant Lines: 30068
💛 - Coveralls

mohammad-alisafaee
mohammad-alisafaee requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf! Please see my comments.

renku/infrastructure/gateway/dataset_gateway.py Outdated Show resolved Hide resolved
tests/cli/test_datasets.py Outdated Show resolved Hide resolved
@Panaetius Panaetius enabled auto-merge (squash) July 5, 2023 10:45
@Panaetius Panaetius merged commit 17a49ae into develop Jul 7, 2023
@Panaetius Panaetius deleted the fic/3463-overwrite-tag branch July 7, 2023 08:27
olevski pushed a commit that referenced this pull request Aug 23, 2023
@Panaetius @olevski
fix(cli): fix overwriting dataset tags (#3497)
ef6d214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

@mohammad-alisafaee mohammad-alisafaee mohammad-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: renku dataset tag dataset-name dataset- [...]
4 participants
@Panaetius @coveralls @olevski @mohammad-alisafaee