Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to user footer #152

Merged
merged 4 commits into from
May 25, 2023
Merged

Conversation

BomberFish
Copy link
Contributor

  • Use gear instead of gearshape for settings icon
  • Limit custom status to one line like the official client

@Sjmarf
Copy link
Contributor

Sjmarf commented May 15, 2023

Icon comparison for convenience:

gear:

gear@4x

gearshape.fill:

gearshape fill@4x

I don't have a preference as to which one is better - it depends whether we want to prefer apple's design style or Discord's. The first is much more apple-like, the second looks similar to what Discord uses in their app.

@BomberFish
Copy link
Contributor Author

BomberFish commented May 15, 2023

I was (finally!) able to get Xcode builds working (updating to 14.3 final worked), so here's the user footer with my changes:

Screenshot taken on 2023-05-15 at 13 55 39

I was thinking of making the status a scrolling "marquee" text, but I felt that would be unnecessary as you could already see that in the user popout.

@cryptoAlgorithm
Copy link
Member

Yup, I actually decided on the filled gear as I felt that matched Discord's style better. However it's clear we are after a more native look that flows with system apps, and as such I'll probably be merging this PR.

Copy link
Member

@cryptoAlgorithm cryptoAlgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not commit modifications to code signing settings (including development team) to prevent breaking CI builds and for consistency.

Swiftcord.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Swiftcord.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Swiftcord.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Swiftcord.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Swiftcord.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Swiftcord.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Copy link
Member

@cryptoAlgorithm cryptoAlgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not commit modifications to code signing settings (including development team) to prevent breaking CI builds and for consistency.

@cryptoAlgorithm cryptoAlgorithm added this pull request to the merge queue May 25, 2023
Merged via the queue into SwiftcordApp:main with commit 89f4833 May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants