-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Create Episode Proposal Template #19
Conversation
|
||
* Proposal: [PR#n]([link to PR]) | ||
* Authors: [Name]([github profile], ... | ||
* Review Manager: [Name]([github profile]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concept of a review manager could be interesting where a member of the podcast core team or review managers team (which hopefully can expand in the future) can take on this role to ensure adequate support and stewardship is applied to each episode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, especially to have one contact person for questions and to keep the status up-to-date.
Would we want to make this an issue template so the process of using the template is a bit easier? This sounds perfect for it! |
|
||
# [TITLE] | ||
|
||
* Proposal: [PR#n]([link to PR]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this need an associated pull request, or will it just be an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or are you thinking to have all proposals be a pull request, like with swift-evolution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all proposals would be a PR and that the proposal would be updated to include the PR# and link to PR. Might be overkill but I will try and see. what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that sounds good!
|
||
* Proposal: [PR#n]([link to PR]) | ||
* Authors: [Name]([github profile], ... | ||
* Review Manager: [Name]([github profile]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, especially to have one contact person for questions and to keep the status up-to-date.
|
||
Brief description of how you intend to contribute to this episode and help make it a reality | ||
|
||
## Source compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
* Proposal: [PR#n]([link to PR]) | ||
* Authors: [Name]([github profile], ... | ||
* Review Manager: [Name]([github profile]) | ||
* Status: [Proposed, Pre-production, Production, Post-production, Published](link to episode if published) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status would be updated overtime just like swift evolution. could be tedious but could be fun :)
Do you think an Issue as opposed to a PR would serve the Episode Proposal concept better? Or am I misunderstanding your suggestion...? |
I think will be good a field of "target audience". It's not the same people that approaching the podcast with advanced profiles and higher level topics such as library implementations or people who come to the podcast out of curiosity and to learn, who want to enter the world of Swift. I think there should be room for all of them. For example: basic, intermediate, advanced and expert as values in target audience. In that way, people will know exactly what they're going to hear. |
After thinking about it a bit more, I think I was on the wrong path — doing this through actual pull requests sounds a lot better. So disregard what I suggested there :) |
@applecoding I think its a good idea. I am going to merge this now and then feel free to open a PR that adds that. |
In conjunction with #18 an Episode Proposal Template could be useful to make it easy for people to propose new episode ideas. This is inspired by both the Swift Weekly Brief process for contributing issues and the Swift evolution process for proposing language changes.