Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.3.1 - The Safe Mode Hotfix, because bugs exist for some reason #214

Merged
merged 46 commits into from
Jan 12, 2021

Conversation

Sv443
Copy link
Member

@Sv443 Sv443 commented Dec 26, 2020

@Sv443 Sv443 added the bug Something isn't working label Jan 5, 2021
@Sv443 Sv443 linked an issue Jan 5, 2021 that may be closed by this pull request
@Sv443 Sv443 changed the title WIP: Version 2.3.1 - The Safe Mode Hotfix, because bugs exist for some reason Version 2.3.1 - The Safe Mode Hotfix, because bugs exist for some reason Jan 5, 2021
jokeErrors.push(`Joke format version "${joke.formatVersion}" doesn't match up with required version "${this.jokeFormatVersion}"`);
jokeObj.formatVersion = false; // TODO: repeat this for everything below
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to take a look at this before the new version is released

Copy link
Member Author

@Sv443 Sv443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@Sv443
Copy link
Member Author

Sv443 commented Jan 10, 2021

why you taking so long mister lgtm bot?

@lgtm-com
Copy link

lgtm-com bot commented Jan 10, 2021

This pull request introduces 1 alert when merging ddf8d9f into 0ecdf25 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

Copy link
Member Author

@Sv443 Sv443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member Author

@Sv443 Sv443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependent This issue submits a project to JokeAPI's dependent lists documentation The issue relates to the documentation enhancement New feature or request
Projects
None yet
2 participants