Release 1.4.0 - Support of ink! 3.0.0-rc10 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikbratashchuk
force-pushed
the
ink-rc8
branch
from
516c726 to
c5aefe8
Compare
|
You also will be useful to check that PR: https://github.com/Supercolony-net/openbrush-contracts/pull/49/files |
After rc7 we don't need to support generation for two kind of the code.
This reverts commit 37a244b.
yarikbratashchuk
force-pushed
the
ink-rc8
branch
from
6a27836 to
30c8ed3
Compare
|
Okay, I'm leaving it as it is. |
VargSupercolony
suggested changes
Feb 21, 2022
CI is still broken we need a right version of redspot and image with node. Locally all tests are passed.
Updated the code to use references in `Mapping`. Increased the time for integration tests.
xgreenx
changed the title
xgreenx
changed the title
xgreenx
requested review from
xgreenx,
coreggon11,
PierreOssun,
sventime and
VargSupercolony
and removed request for
xgreenx
coreggon11
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing of:
use-ink/ink#1131
use-ink/ink#982
use-ink/ink#1145
We are able to use the latest ink! =) At the moment it points to
master, but then the3.0.0-rc10release will be ready we will point on it.Updated contract to be compatible with latest
contract-pallet.Simplified the brush's codegen, now we don't need to worry about the
ink-as-dependencyfeature.Of course, reduction of the size of the code!=) All contracts are moved to use
Mappinginstead ofStorageHashMap. All values are passed by reference instead of move.At the moment only
substrate-contracts-nodeworks correctly with the latest ink, so integration tests take a lot of time.Most of the documentation is updated, but not all. We will update it fully in follow-up PR.