-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch: Health api added #56
Fetch: Health api added #56
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
package.json
Outdated
@@ -28,17 +28,19 @@ | |||
"@nestjs/core": "^10.0.0", | |||
"@nestjs/mapped-types": "^2.0.2", | |||
"@nestjs/mongoose": "^10.0.0", | |||
"@nestjs/platform-express": "^10.0.0", | |||
"@nestjs/platform-express": "^10.4.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove package json and lock changes from PR
src/main.ts
Outdated
// Access the Fastify instance to define the health check endpoint | ||
const fastifyInstance = app.getHttpAdapter().getInstance(); | ||
|
||
fastifyInstance.get('/ping', async (request: FastifyRequest, reply: FastifyReply) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to write complicated code for normal ping API write this in controller rather in main.ts file
src/main.ts
Outdated
|
||
async function bootstrap() { | ||
const app = await NestFactory.create<NestFastifyApplication>( | ||
AppModule, | ||
new FastifyAdapter(), | ||
); | ||
|
||
await app.register(compression,{ | ||
await app.register(compression, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please dont add changes from files in PR
|
2bd2cb7
into
Sunbird-ALL:release-1.3-test-rig
Fetch: Health api added