-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): pkg trigger and release workflow updates #1693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amdprophet
force-pushed
the
ci-improvements
branch
from
November 1, 2024 01:30
7233617
to
1357ab0
Compare
amdprophet
changed the title
chore(ci): use workflow for pkg trigger, remove release support
chore(ci): pkg trigger and release workflow updates
Nov 1, 2024
amdprophet
force-pushed
the
ci-improvements
branch
2 times, most recently
from
November 4, 2024 20:27
aa1e5b1
to
5620844
Compare
Packaging is now only triggered from Dev & PR builds. The only input sent when triggering packaging is now the Workflow Run ID of the workflow run that packaging should pull its artifacts from. The version of otelcol-sumo & otelcol-config is now determined using a combination of the otelcol_version in `otelcolbuilder/.otelcol-builder.yaml` and git tags. Releases are no longer triggered by the creation of a tag. A release can now be triggered via the new 'Publish release' workflow. The new release workflow requires the ID of a workflow run that contains the artifacts to be released. The Git SHA used to build the otelcol-sumo binary is now included in the version of the --version flag. Signed-off-by: Justin Kolberg <[email protected]>
amdprophet
force-pushed
the
ci-improvements
branch
from
November 4, 2024 20:29
5620844
to
ee8de42
Compare
echlebek
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the release instructions: https://github.com/SumoLogic/sumologic-otel-collector/blob/main/docs/release.md
amdprophet
force-pushed
the
ci-improvements
branch
from
November 4, 2024 21:48
1dd9c9a
to
ee8de42
Compare
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Added. |
echlebek
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packaging is now only triggered from Dev & PR builds. The only input sent when triggering packaging is now the Workflow Run ID of the workflow run that packaging should pull its artifacts from.
The version of otelcol-sumo & otelcol-config is now determined using a combination of the otelcol_version in
otelcolbuilder/.otelcol-builder.yaml
and git tags.Releases are no longer triggered by the creation of a tag. A release can now be triggered via the new 'Publish release' workflow. The new release workflow requires the ID of a workflow run that contains the artifacts to be released.
The Git SHA used to build the otelcol-sumo binary is now included in the version of the
--version
flag.Signed-off-by: Justin Kolberg [email protected]