Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s_tagger) Removing k8s tagger warnings, as these have been causing false alarms and cost concerns #1681

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

rnishtala-sumo
Copy link
Contributor

Removing k8s tagger warnings, as these have been causing false alarms and cost concerns

@rnishtala-sumo rnishtala-sumo requested a review from a team as a code owner October 3, 2024 18:44
@echlebek
Copy link
Collaborator

echlebek commented Oct 3, 2024

@rnishtala-sumo is it worth making these debug level instead of removing them? Do they carry any debugging value?

@rnishtala-sumo
Copy link
Contributor Author

@echlebek they only indicate that the cache doesn't yet have expected entry. In most cases it gets there eventually. Having said that, Debug is probably a better option.

@rnishtala-sumo rnishtala-sumo force-pushed the k8s-tagger-warnings branch 2 times, most recently from 791863a to 63f27ad Compare October 3, 2024 18:59
@echlebek
Copy link
Collaborator

echlebek commented Oct 3, 2024

Seems like it would only be useful to say how long the cache has been out of sync for, or maybe only log if it's been out of sync for a much longer period than expected. That said, this is still an improvement. 👍

@chan-tim-sumo
Copy link
Contributor

Should this go down to Info level from warn level instead of going to debug? because i'm thinking this still runs in production right? and if i remember correctly, debug is disabled in production 🤔

@rnishtala-sumo
Copy link
Contributor Author

@chan-tim-sumo The goal is to not see them in prod by default. But have the option of enabling them. Debug is used for such use cases.

@rnishtala-sumo rnishtala-sumo merged commit 5e2bad8 into main Oct 3, 2024
43 checks passed
@rnishtala-sumo rnishtala-sumo deleted the k8s-tagger-warnings branch October 3, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants