Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golang version to 1.21.4 #1364

Merged
merged 7 commits into from
Dec 6, 2023
Merged

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Dec 4, 2023

Crucial change is

powershell -command "Set-ItemProperty -Path HKLM:\System\CurrentControlSet\Control\Lsa\FipsAlgorithmPolicy -Name Enabled -Value \$true"

which enables FIPS backend on Windows

@github-actions github-actions bot added documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code labels Dec 4, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Dec 4, 2023
@sumo-drosiek sumo-drosiek force-pushed the drosiek-build-1.21 branch 2 times, most recently from cf5f666 to b289f65 Compare December 4, 2023 14:27
@github-actions github-actions bot removed the github_actions Pull requests that update Github_actions code label Dec 5, 2023
Dominik Rosiek and others added 6 commits December 5, 2023 15:07
@sumo-drosiek sumo-drosiek marked this pull request as ready for review December 5, 2023 14:19
@sumo-drosiek sumo-drosiek requested a review from a team as a code owner December 5, 2023 14:19
@swiatekm swiatekm requested a review from amdprophet December 5, 2023 14:27
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like @amdprophet to have a look as well as the author.

@sumo-drosiek
Copy link
Contributor Author

sumo-drosiek commented Dec 6, 2023

Merging as #1369 is failing for some reason (only on github, linux, fips test)

@sumo-drosiek sumo-drosiek merged commit 947844c into main Dec 6, 2023
28 checks passed
@sumo-drosiek sumo-drosiek deleted the drosiek-build-1.21 branch December 6, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants