feat(exporter/awss3): add AWS S3 exporter #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
swiatekm
approved these changes
Jun 1, 2023
| @@ -261,6 +261,7 @@ The rest of the components in the table are pure upstream OpenTelemetry componen | |||
| [tailsamplingprocessor]: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/v0.78.0/processor/tailsamplingprocessor | |||
| [transformprocessor]: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/v0.78.0/processor/transformprocessor | |||
|
|
|||
| [awss3exporter]: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/v0.78.0/exporter/awss3exporter | |||
There was a problem hiding this comment.
Do we need a fork of the s3 exporter too, if we're thinking about supporting the archive format that the installed collector uses?
There was a problem hiding this comment.
maybe related to this discussion https://github.com/open-telemetry/opentelemetry-collector/issues/6272#issuecomment-1572232658
There was a problem hiding this comment.
We can do that if/when we have the fork ready. For now, let's add the upstream version as is.
rnishtala-sumo
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added to Contrib in v0.77.0.