add custom labels to fluentd sts and setup job pods #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic/sumologic-kubernetes-collection into vsinghal-add-custom-labels
vsinghal13
requested review from
frankreno,
samjsong and
sumo-drosiek
and removed request for
frankreno and
samjsong
frankreno
approved these changes
Aug 4, 2020
| @@ -9,6 +9,9 @@ metadata: | |||
| labels: | |||
| app: {{ template "sumologic.labels.app.setup.job" . }} | |||
| {{- include "sumologic.labels.common" . | nindent 4 }} | |||
| {{- if .Values.sumologic.setup.job.podLabels }} | |||
There was a problem hiding this comment.
I would add the common set here as well i think
|
We should add this to the otelcol as well 😅 |
…ogic/sumologic-kubernetes-collection into vsinghal-add-custom-labels
|
Good call on OTELCOL, we should add them there too as it will be needed. |
Co-authored-by: Sam Song <[email protected]>
sumo-drosiek
approved these changes
Aug 6, 2020
|
Customers should be aware that changing the labels for existing installation need to be done with cc: @frankreno |
3 tasks
|
@sumo-drosiek I'm trying to reproduce the error with labels and/or annotations and can't do it, I don't need to provide the |
|
@perk-sumo even if you change value of the label during upgrade? |
|
Yes, I've tested this with latest 1.2.3 and see no issue with fresh install nor upgrade. |
|
@perk-sumo, confirming 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configs:
sumologic.podLabels-> add labels to fluentd sts, setup job, otelcol deploymentfluentd.podLabels-> add labels to all fluentd sts.fluentd.logs.statefulset.podLabels-> add labels only to logs fluentd sts.fluentd.metrics.statefulset.podLabels-> add labels only to metrics fluentd sts.fluentd.events.statefulsetpodLabels-> add labels only to events fluentd sts.otelcol.deployment.podLabels-> add labels only to otelcol deployment.sumologic.setup.job.podLabels-> add labels only to setup job.Testing performed