Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade script grep sed bash fixes #647

Merged
merged 8 commits into from
May 20, 2020
Merged

Upgrade script grep sed bash fixes #647

merged 8 commits into from
May 20, 2020

Conversation

perk-sumo
Copy link
Contributor

@perk-sumo perk-sumo commented May 19, 2020 •
edited
Loading

Description

Fixes #644

  • fix for upgrade script doesn't work under GNU sed >= 4.4
  • upgrade needs recent GNU Bash but doesn't check for that
  • grep does not have to be modern
  • allow for newer yq
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo added this to the v1.0 milestone May 19, 2020
frankreno
frankreno approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sumo-drosiek
sumo-drosiek approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I was non-synced with git repo -> #652

@sumo-drosiek
Copy link
Contributor

Could you add vagrant/provision.sh update from my PR?

@perk perk mentioned this pull request May 20, 2020
Closed
3 tasks
sumo-drosiek
sumo-drosiek approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo merged commit 3db2b0d into master May 20, 2020
@perk-sumo perk-sumo deleted the upgrade-script-grep-sed-bash-fixes branch May 20, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@vsinghal13 vsinghal13 Awaiting requested review from vsinghal13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Multiple problems with upgrade script
4 participants
@perk-sumo @sumo-drosiek @frankreno @samjsong