-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List metrics forwarded to the sumologic #629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like this idea, a lot because it is clear. Left on comment. Also cc @arunpatyal - might be worth comparing to your doc, this way we can be clear about what data we collect.
# prometheus_remote_storage_shards_min | ||
# prometheus_remote_storage_string_interner_zero_reference_releases_total | ||
# prometheus_remote_storage_succeeded_samples_total | ||
# up | ||
- url: http://$(CHART).$(NAMESPACE).svc.cluster.local:9888/prometheus.metrics | ||
writeRelabelConfigs: | ||
- action: keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing fluentd/bit/otel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was basing on metrics test. Need to run setup with logs and tracing to do full completion
Solves #603 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add the one's present in the last remote write queue as well
# prometheus_remote_storage_shards_min | ||
# prometheus_remote_storage_string_interner_zero_reference_releases_total | ||
# prometheus_remote_storage_succeeded_samples_total | ||
# up | ||
- url: http://$(CHART).$(NAMESPACE).svc.cluster.local:9888/prometheus.metrics | ||
writeRelabelConfigs: | ||
- action: keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given pending comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it :)
Please re-request the review when the comments issues are fixed.
I updated list of metrics with fluentd, fluent-bit and otelcol :) |
ac109d5
to
9245e66
Compare
8396118
to
a3d8392
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Add list of metrics which we forward to the sumologic
Testing performed