Expose otelcol UDP enpoints too #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmm-sumo
changed the title
| protocol: UDP | ||
| - containerPort: 6832 # Default endpoint for Jaeger Thrift Binary receiver. | ||
| protocol: UDP | ||
| - containerPort: 8888 # Default endpoint for querying metrics. |
There was a problem hiding this comment.
It would be nice to add it to the prometheus :)
There was a problem hiding this comment.
I can take care about it, some day :D
There was a problem hiding this comment.
This is a very good point, we have been asked about that already BTW
| - containerPort: 14250 # Default endpoint for Jaeger gRPC receiver. | ||
| - containerPort: 9411 # Default endpoint for Zipkin receiver. | ||
| - containerPort: 8888 # Default endpoint for querying metrics. | ||
| - containerPort: 55678 # Default endpoint for Opencensus receiver. |
| protocol: TCP | ||
| targetPort: 55678 | ||
| - name: jaeger-sampling # Default endpoint for Jaeger Sampling (if enabled) | ||
| port: 5778 |
There was a problem hiding this comment.
Does it listen on 0.0.0.0?
There was a problem hiding this comment.
Good catch. Right now, it's just a first step towards enabling remote sampling. Sampling itself requires separate entry in the configuration and we'll need to provide the details in the guide. So the purpose of that (as for now) is to just make less changes to values.yaml
sumo-drosiek
added
enhancement
sumo-drosiek
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jaeger Client typically uses UDP
thrift-compactprotocol for sending spans. Lets expose it by defaultTesting performed