Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the dynamic namespace env variable to be fluentd namespace #471

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

This PR changes the dynamic namespace env variable to be fluentd namespace for the prometheus remote write URL's.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 requested review from samjsong and perk-sumo March 6, 2020 19:43
@samjsong
Copy link
Contributor

samjsong commented Mar 6, 2020

If Prometheus and Fluentd are deployed on different namespaces, can Prometheus access the configmap that is deployed on the namespace that Fluentd is on?

@samjsong samjsong added this to the v0.16 milestone Mar 6, 2020
@vsinghal13
Copy link
Contributor Author

If Prometheus and Fluentd are deployed on different namespaces, can Prometheus access the configmap that is deployed on the namespace that Fluentd is on?

No, for that we copy over the configmap to the namespace where Prometheus is running. The same is documented in the existing Prometheus Operator steps.

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vsinghal13 vsinghal13 merged commit 56c58a5 into master Mar 16, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-add-namespace-configmap branch March 16, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants