feat: fix serviceMonitor for additional daemonsets #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
reviewed
Jul 26, 2023
deploy/helm/sumologic/values.yaml
Outdated
| @@ -649,7 +649,7 @@ sumologic: | |||
| - port: metrics | |||
| selector: | |||
| matchLabels: | |||
| sumologic.com/app: otelcol-logs-collector | |||
| sumologic.com/app-name: otelcol-logs-collector | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
But these selectors are for the Service, not the Daemonset.
There was a problem hiding this comment.
oh, I was trying figure out why e2e are failing 🤦
sumo-drosiek
force-pushed
the
drosiek-fix-serviceMonitor
branch
from
9a42a55 to
90745dd
Compare
added 2 commits
July 27, 2023 09:06
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-fix-serviceMonitor
branch
from
90745dd to
093ba0e
Compare
swiatekm
reviewed
Jul 27, 2023
| @@ -1,136 +1,4 @@ | |||
| --- | |||
| # Source: sumologic/templates/events/common/service.yaml | |||
There was a problem hiding this comment.
Why are these resources removed from this file? Were they unused, and regenerating the file caused them to disappear?
There was a problem hiding this comment.
I think something is wrong and only one object is put into the generated file
sumo-drosiek
commented
Jul 27, 2023
Signed-off-by: Dominik Rosiek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Match correct label: