Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename public.ecr.aws/sumologic/kubectl to public.ecr.aws/sumologic/kubernetes-tools-kubectl #2983

Merged
merged 3 commits into from
Apr 14, 2023
Merged

feat: rename public.ecr.aws/sumologic/kubectl to public.ecr.aws/sumologic/kubernetes-tools-kubectl #2983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e60720b
feat: rename public.ecr.aws/sumologic/kubectl to public.ecr.aws/sumol…
Apr 13, 2023
2f74cea
chore: change image tag to 2.20.0 (in advance)
Apr 13, 2023
629845f
refactor(pvc-cleaner): fix sorting for busybox sort
Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/2983.changed.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
feat: rename public.ecr.aws/sumologic/kubectl to public.ecr.aws/sumologic/kubernetes-tools-kubectl
4 changes: 2 additions & 2 deletions deploy/helm/sumologic/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,8 +573,8 @@ The following table lists the configurable parameters of the Sumo Logic chart an
| `kube-prometheus-stack.prometheus.prometheusSpec.nodeSelector` | Node selector for prometheus. [See docs/Best_Practices.md for more information.](/docs/best-practices.md) | `{}` |
| `pvcCleaner.metrics.enabled` | Flag to enable cleaning unused PVCs for otelcol metrics statefulsets. | `false` |
| `pvcCleaner.logs.enabled` | Flag to enable cleaning unused PVCs for otelcol logs statefulsets. | `false` |
| `pvcCleaner.job.image.repository` | Image repository for pvcCleaner docker containers. | `public.ecr.aws/sumologic/kubectl` |
| `pvcCleaner.job.image.tag` | Image tag for pvcCleaner docker containers. | `1.26.3` |
| `pvcCleaner.job.image.repository` | Image repository for pvcCleaner docker containers. | `public.ecr.aws/sumologic/kubernetes-tools-kubectl` |
| `pvcCleaner.job.image.tag` | Image tag for pvcCleaner docker containers. | `2.20.0` |
| `pvcCleaner.job.image.pullPolicy` | Image pullPolicy for pvcCleaner docker containers. | `IfNotPresent` |
| `pvcCleaner.job.resources` | Resource requests and limits for the pvcCleaner containers. | `{"limits": {"memory": "256Mi", "cpu": "2000m"}, "requests": {"memory": "64Mi", "cpu": "100m"}}` |
| `pvcCleaner.job.nodeSelector` | Node selector for pvcCleaner job. [See docs/best-practices.md for more information.](/docs/best-practices.md) | `{}` |
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/sumologic/conf/pvc-cleaner/pvc-cleaner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function check_hpa_exists() {
function get_sorted_pvcs() {
kubectl -n "${NAMESPACE}" get pvc --selector="${PVC_SELECTOR}" --no-headers \
| awk '{print $1}' \
| sort --version-sort
| sort -V
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Busybox doesn't support long arguments

}

function get_pvcs_count() {
Expand Down
4 changes: 2 additions & 2 deletions deploy/helm/sumologic/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4563,8 +4563,8 @@ pvcCleaner:

job:
image:
repository: public.ecr.aws/sumologic/kubectl
tag: 1.26.3
repository: public.ecr.aws/sumologic/kubernetes-tools-kubectl
tag: 2.20.0
pullPolicy: IfNotPresent

resources:
Expand Down