Only pass in our own yamls to helm template cmd #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sie-fix-helm-template
…ic/sumologic-kubernetes-collection into maisie-fix-helm-template
yuting-liu
force-pushed
the
yuting-helm-dependency
branch
from
e2a43fb to
f256377
Compare
…ic/sumologic-kubernetes-collection into maisie-fix-helm-template
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After adding dependencies into our helm chart,
helm templatewill render not only our own yaml templates but also the yaml templates from all of the dependent charts. To render only our templates, we use the-xoption for each .yaml file undersumologic/templatesfolder in thehelm templatecommand.Testing performed