Security: Pinned colors library to 1.4.0 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/ We don't use other libraries mentioned in there, so we're good on those.
plocket
added
bug
|
Draft until we can test the action. See #489. |
This won't fix this for all our dependents because most of them don't use the action, but this will fix it for those that use the action.
BryceStevenWilley
approved these changes
Jan 10, 2022
|
Confirmed as working at https://github.com/plocket/docassemble-CompositeActionsTest/actions/runs/1678835970. This is for v3, so I'm going to make the same change in v4. I might do special admin magic to be able to merge it myself [with these PR changes for reference]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it's a security issue, I already published it.
I think. I'd love a double check on this because I published before I committed and I don't recall if that flow is sufficient.I'm just going to check it myself. Faster that way.See https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/
We don't use other libraries mentioned in there, so we're good on those.