-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigured Yarn and package.json with more universal approach #158
Reconfigured Yarn and package.json with more universal approach #158
Conversation
+ added support for "engines" field
Task linked: CU-86azuzuv9 Improve .yarnrc.yml configuration |
Seems like we are maintaining another binary file in our repo with this update instead of the yarn4.1.1 binary. Just don't want the hassle of maintaining binaries to fall on us later down the road. But if the team agrees this is the best approach, then we can just move forward with this change we have a line "packageManager": "[email protected]" in package.json, is that not enough to enforce the correct yarn is being used? |
I agree with @ItsAdel - let's not add a package manager to the repo, it's a strange practice. |
@@ -0,0 +1,11 @@ | |||
/* eslint-disable */ | |||
// prettier-ignore | |||
// noinspection ES6ConvertVarToLetConst,UnnecessaryLocalVariableJS,CommaExpressionJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please specify the version in package.json rather than get extra files in repo
This specific binary is used specifically as a plugin, which is also mentioned in |
My approach would be to leave out the binaries for now until this feature is natively needed. Strict enforcing of yarn 4.1.1 in our package manager is not necessary. Remove all that is causing the build to fail. In our CI/CD pipeline (Dockerfile), we ensure the correct yarn file is being installed anyways.
And in our local environment, our team is small enough to have this just in the documentation somewhere (README) or just be tribal knowledge. I would steer away from over complicating it. |
Makes sense, scratched that |
@@ -5,6 +5,11 @@ | |||
"cacheDirectories": [ | |||
".next/cache" | |||
], | |||
"engineStrict": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, f... I didn't see that comment. I guess I'll make a quick fix?
Summary
.yarnrc.yml
for universality and better compatibilityengines
field inpackage.json
Ticket ID/Link to ClickUp
Improve .yarnrc.yml configuration
Checklist