-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable selector-specific stdin filename for buffers #326
enable selector-specific stdin filename for buffers #326
Conversation
d75c8c3
to
140e691
Compare
FYI. Added comment to disable linter error on line 25. This appears to be a preexisting issue. It's unclear to me what the purpose of this line is. |
140e691
to
380be4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some remarks here but I really like the approach and PR.
380be4c
to
2be661f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the type annotation thing, this is fine and can be merged.
7653f3a
to
ad8dbe1
Compare
Let's do this. LGTM. |
Adds logic to use selector specific dummy filenames for unsaved buffers. Replaces dummy filenames with "stdin" when parsing linter output in the same manner that is currently implemented for "".
Also includes the addition of plugin support for 2 common YAML plugins. These additions are not core to this change, but are related and necessary to add dummy file extension support for YAML.
A further improvement to this change would be to move the mapping of selectors to file extensions to the config file, but because this is closely coupled to the plugins config, it would make sense to move both to the config file (if possible) at the same time.