-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline coloring #100
Comments
Here's a case where the line gets interrupted on the way: jquery/jquery#1496 |
I think this should work pretty good, at least for the final line-break: .discussion-timeline:before {
height: calc(100% - 322px) !important;
} |
LOL I forgot about the Are you going to add this?... nevermind! LOL |
One issue thought, when the comment box expands higher, the line will be visible again :( |
I just closed and reopened this issue to show the reopen icon that I just added a style for... should that center dot be the same as the background or maybe a lighter green? |
maybe match the user's color? |
Either #eee or #222, but I'm leaning towards #eee. |
Dot color was fixed in 5d8619e |
Continuing the discussion from the code
I tried this bit of css... the length may not work with percentages well. For example, this css (with an 85% stop) works great for this issue with 13 comments
Issue 79 with 25 comments needs the stop set at around 90%, and issue 98 with one comment needs it set to about 50%.
The text was updated successfully, but these errors were encountered: