Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline coloring #100

Closed
Mottie opened this issue Jan 29, 2014 · 8 comments
Closed

Timeline coloring #100

Mottie opened this issue Jan 29, 2014 · 8 comments

Comments

@Mottie
Copy link
Member

Mottie commented Jan 29, 2014

Continuing the discussion from the code

I tried this bit of css... the length may not work with percentages well. For example, this css (with an 85% stop) works great for this issue with 13 comments

.new-discussion-timeline .discussion-timeline:before {
  left: -79px !important; /* only added for testing so you can see where the line ends */
  background: -webkit-linear-gradient(top, 
    rgba(51,51,51,1) 0%,
    rgba(51,51,51,1) 85%,
    rgba(51,51,51,0) 85%,
    rgba(0,0,0,0) 100%
  ) !important;
  background: -moz-linear-gradient(top,
    rgba(51,51,51,1) 0%,
    rgba(51,51,51,1) 85%,
    rgba(51,51,51,0) 85%,
    rgba(0,0,0,0) 100%
  ) !important;
}

Issue 79 with 25 comments needs the stop set at around 90%, and issue 98 with one comment needs it set to about 50%.

@silverwind
Copy link
Member

Here's a case where the line gets interrupted on the way: jquery/jquery#1496

@silverwind
Copy link
Member

I think this should work pretty good, at least for the final line-break:

  .discussion-timeline:before {
    height: calc(100% - 322px) !important;
  }

silverwind added a commit that referenced this issue Jan 30, 2014
@Mottie
Copy link
Member Author

Mottie commented Jan 30, 2014

LOL I forgot about the calc property.. that's perfect!

Are you going to add this?... nevermind! LOL

@silverwind
Copy link
Member

One issue thought, when the comment box expands higher, the line will be visible again :(

@Mottie Mottie closed this as completed Jan 30, 2014
@Mottie Mottie reopened this Jan 30, 2014
@Mottie
Copy link
Member Author

Mottie commented Jan 30, 2014

I just closed and reopened this issue to show the reopen icon that I just added a style for... should that center dot be the same as the background or maybe a lighter green?

@ddavison
Copy link
Member

maybe match the user's color?

@silverwind
Copy link
Member

Either #eee or #222, but I'm leaning towards #eee.

@silverwind
Copy link
Member

Dot color was fixed in 5d8619e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants