Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the 'private' tags to black #222

Merged
merged 1 commit into from
Apr 3, 2015
Merged

Changed the 'private' tags to black #222

merged 1 commit into from
Apr 3, 2015

Conversation

EvanDarwin
Copy link
Contributor

@silverwind
Copy link
Member

Thanks!

If you don't mind, I'd like to see the class .repo-private-label (don't think span is necessary) added to these two selector lists:

.summary-stats li a:hover {

button.button, button.minibutton, a.minibutton, .button.primary:hover, .pagination .current, .pagination .current:hover {

The colors there are pretty close to yours and we try to not introduce new groups unless necessary.

@EvanDarwin
Copy link
Contributor Author

Made the requested changes. 😄

@silverwind
Copy link
Member

Did you push to the right branch? Not seeing a new commit 😉

@EvanDarwin
Copy link
Contributor Author

Overwrote the old one so I don't dirty up the history. The changes were made though.

@ddavison
Copy link
Member

ddavison commented Apr 3, 2015

your files haven't changed @EvanDarwin , I'm not sure you understood him 😃 you did take the span out of the specificity, yes, but that's not all he wanted.

What he wanted, is for you to move your .repo-private-label into another selector list.

.some_selector, .repo-private-label {

Combine them with other selectors with similar properties. we don't like to introduce new selector groups if we don't have to.

Does this make sense?

@silverwind
Copy link
Member

Yeah, what I meant was to add .repo-private-label to both lines I linked.

@EvanDarwin
Copy link
Contributor Author

Oh sorry, I did misunderstand. I thought you just wanted me to use the same colors as those blocks assigned. 😛

Changes have been made again.

silverwind added a commit that referenced this pull request Apr 3, 2015
Changed the 'private' tags to black
@silverwind silverwind merged commit c26e3ab into StylishThemes:master Apr 3, 2015
@silverwind
Copy link
Member

Looking good. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants