-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the 'private' tags to black #222
Conversation
EvanDarwin
commented
Apr 2, 2015
Thanks! If you don't mind, I'd like to see the class Line 637 in bcddff8
Line 942 in bcddff8
The colors there are pretty close to yours and we try to not introduce new groups unless necessary. |
Made the requested changes. 😄 |
Did you push to the right branch? Not seeing a new commit 😉 |
Overwrote the old one so I don't dirty up the history. The changes were made though. |
your files haven't changed @EvanDarwin , I'm not sure you understood him 😃 you did take the What he wanted, is for you to move your
Combine them with other selectors with similar properties. we don't like to introduce new selector groups if we don't have to. Does this make sense? |
Yeah, what I meant was to add |
Oh sorry, I did misunderstand. I thought you just wanted me to use the same colors as those blocks assigned. 😛 Changes have been made again. |
Changed the 'private' tags to black
Looking good. Thanks for contributing! |