-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not too bright (my corneas cried for help) not too dark #358
Conversation
Hi @un1versal! I've already bumped up the brightness of most of the text a bit. I think going from Was this PR just for the placeholders? |
@@ -415,7 +415,7 @@ | |||
.inline-form .btn-plain, .pr-toolbar, .diffbar, .shade-gradient, | |||
#categories .list, .gist-banner, .select-menu-item-parent, .main-content, | |||
.showcase-page-header, .showcase-page-pattern:after, .description-inline, | |||
.result-group a, .border-wrap, .select-menu-item, a.feed-icon { | |||
.result-group a, .border-wrap, .select-menu-item, a.feed-icon, session-current { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its easier if you click https://github.com/settings/security, since it is under security it contains sensitive info, mmmm
session-device session-current should be it, I think my fix was only in a dream.
this doesnt work. Ill revert.
screenshot
see the background shouldnt be grey like that should be dark or transparent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs fixing though, idk why but I cant do it
Youre mixing things up... we go from #f5f5f5 and #fff to less brighter #e2e2e2 remember, toke, toke, pass.... |
Can you squash these commits? |
let me get a press... would you like some commit juice? @Mottie, done monsieur |
imo this whole selectors bunch needs segregating selectively, else some bits are just too dull
@Mottie this looks good but not so bright that it pierces corneas
in other places slightly too dark on the dull side, check it.