Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change yellow to brown #184

Closed
Mottie opened this issue Oct 3, 2014 · 10 comments
Closed

Change yellow to brown #184

Mottie opened this issue Oct 3, 2014 · 10 comments

Comments

@Mottie
Copy link
Member

Mottie commented Oct 3, 2014

I really don't like the yellow panel color... I thought I changed it to look more brown in the past, but it looks like it's yellow again.

For example, if you look at the ProTip on this page you'll see this:

2014-10-03 11_35_14-trending repositories on github today

I'd like to change it to brown, or some other color, not puke yellow:

2014-10-03 11_34_22-trending repositories on github today

  /* === Yellow panel === */
  #feedHeaderContainer, .feedBackground, .infotip, .form-actions .tip, .mini-callout, .snippet em, #message .sent, .notification,
  .callout, .contributing, .ejector, #issues_search .results em, .bootcamp-help ul li, .btn-download, .feature-tabs .tab-button,
  .plan.free, #message.minor, .chzn-results li em, #missing-readme, .warning, .page-notice, a.button.classy, .signed-out-comment,
  .facebox-alert, .branch-status.status-pending .discussion-item-icon, .discussion-event-status-renamed .discussion-item-icon,
  .state-indicator.renamed, .discussion-topic .branch-status.status-pending, .form-checkbox label em.highlight,
  .recently-touched-branches, .secret .repo-label span, .protip-callout, .compare-pr-placeholder {
    background: #321 !important;
    border-color: #542 !important;
    color: #b74;
  }
  /* Travis build in progress, merge status unknown */
  .branch-action-state-unknown .branch-action-body, .branch-action-state-unknown .branch-status,
  .branch-action-state-unstable .branch-action-body, .branch-action-state-unstable .branch-status {
    border-color: #b74 !important;
  }
  .recently-pushed-branch-details, #toc .octicon-diff-modified, .secret .repo-label span {
    color: #b74 !important;
  }
  .recently-pushed-branch-details a, .protip-callout a, .compare-pr-placeholder p, .compare-pr-placeholder .help-link,
  a.status-pending {
    color: #da6 !important;
  }

What do you guys think?

@silverwind
Copy link
Member

If I recall correctly, I didn't really like our shade of brown, so I went with yellow. Your shade of brown up there looks acceptable, compared to the previous one 😉.

@ddavison
Copy link
Member

ddavison commented Oct 3, 2014

maybe you could use the colors of the private repositories

@Mottie
Copy link
Member Author

Mottie commented Oct 3, 2014

What colors are those?

@silverwind
Copy link
Member

For some reason, the color on that linked page is off from your screenshot for me:

screenshot_21

Anyways, I'm ok with brown, if it's a nice almost-orange brown 😉

@dsoegijono
Copy link
Member

Yes to brown. Not a big fan of yellow either.

@silverwind
Copy link
Member

If possible, try not to affect yellow merge status and travis icons.

@Mottie
Copy link
Member Author

Mottie commented Oct 3, 2014

Hmm, that yellow panel color is missing an !important flag.

I'll separate out the stuff that doesn't look like pull-request and just make that brown then

@Mottie Mottie closed this as completed in cab2da4 Oct 3, 2014
silverwind added a commit that referenced this issue Oct 4, 2014
* 'master' of github.com:StylishThemes/GitHub-Dark:
  Settings: Fix sidebar
  version bump
  Alert (blue tips): fix text and link colors
  Fix readme & comment unstyled links
  Compare: Match button text color to links
  Main repo page: fix recently pushed branches notification
  Overall: Add missing !important flag
  Overall: Replace some yellow styles with brown. Fixes #184
  Code View: Make linked highlight more visible
  Global: Tweak green colors
  Global: Make green panels more readable
@ddavison
Copy link
Member

ddavison commented Oct 6, 2014

just wanted to chime in and say this is fucking sexy....

@Mottie
Copy link
Member Author

Mottie commented Oct 6, 2014

Time for a sexy party!

sexy_party

@silverwind
Copy link
Member

imma let you finish ... but my blue boxes are way sexier.

@StylishThemes StylishThemes locked and limited conversation to collaborators Jan 22, 2015
@StylishThemes StylishThemes unlocked this conversation Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants