Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tab size = 4 #159

Closed
silverwind opened this issue Aug 8, 2014 · 6 comments
Closed

Default tab size = 4 #159

silverwind opened this issue Aug 8, 2014 · 6 comments

Comments

@silverwind
Copy link
Member

GitHub's default sheet uses a tab-size of 8, which results in some misalignment on code which uses tabs ands expects a size of 4 (which is pretty common). We could fix this with:

    .highlight pre {
        -webkit-tab-size: 4 !important;
           -moz-tab-size: 4 !important;
                tab-size: 4 !important;
    }

Should I go for it? Any opinions?

@Mottie
Copy link
Member

Mottie commented Aug 8, 2014

That's already been done (ref):

  pre {
    /*[[tab-size]]*/
  }

And the settings on userstyles are set as follows:

2014-08-08 07_06_37-github dark - themes and skins for github - userstyles org

@silverwind
Copy link
Member Author

Ah, alright, I never noticed because I install from GitHub. Maybe I'll add a default size of 4 then.

@silverwind
Copy link
Member Author

@Mottie could this work when you replace the fields on userstyles.org with just the number? My Firefox happily accepts -moz-tab-size: 4 4.

  pre, .highlight {
         tab-size: /*[[tab-size]]*/ 4 !important;
    -moz-tab-size: /*[[tab-size]]*/ 4 !important;
  }

Sample file: https://github.com/NodeBB/NodeBB/blob/master/app.js

@silverwind
Copy link
Member Author

Went ahead and commited it. @Mottie please remember to change the tab-size option fields on userstyles.org to just numbers on next release. I'll leave this issue open as a reminder.

@silverwind silverwind changed the title Proposal: Change tab size to 4 Default tab size = 4 Aug 8, 2014
@silverwind
Copy link
Member Author

Looking good on userstyles.org, thanks!

@Mottie
Copy link
Member

Mottie commented Aug 9, 2014

Oh, oops! I forgot to close this issue ;)

Thanks :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants