Skip to content

Commit

Permalink
Global: Fix repository invitations, fixes #315
Browse files Browse the repository at this point in the history
  • Loading branch information
@silverwind
silverwind committed May 24, 2016
1 parent 9bef194 commit 529462d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions github-dark.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
outline-color: /*[[base-color]]*/ #4183C4 !important;
}
/* inputs */
select, input, textarea {
select, input:not(.btn-link), textarea {
-moz-appearance: none !important;
background: #181818 !important;
border: 1px solid #343434 !important;
Expand Down Expand Up @@ -657,7 +657,8 @@
.tile-block, .tile-bordered:not(:last-child), .showcase-page-header,
.showcase-page-repo-list, .header-search-scope, .exploregrid-item,
.result-group a, .signed-commit-badge, .signed-commit-header,
.user-key-email, .border-top, .pricing-card-cta, .shelf, .access-token {
.user-key-email, .border-top, .pricing-card-cta, .shelf, .access-token,
.border {
border-color: #343434 !important;
}
.discussion-item-icon, .date:after, .render-shell img, img.asset,
Expand Down Expand Up @@ -828,7 +829,8 @@
.commit-tease .commit-meta, .manage-repo-access-icon,
.table-list:not(.team-member-list), .repo-file-upload-progress,
.gcr-ext-editor-dialog, .shade-gray, .exploregrid-item,
.listgroup-item, .signed-commit-badge-small, .facebox-popup, .explore-signup-entice-wrapper {
.listgroup-item, .signed-commit-badge-small, .facebox-popup,
.explore-signup-entice-wrapper, .bg-white {
background: #181818 !important;
}
.sidebar-module {
Expand Down

5 comments on commit 529462d

@silverwind
Copy link
Member Author

@silverwind silverwind commented on 529462d May 24, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new classes: .border, .bg-white are worrysome. Soon, they'll implement https://github.com/marmelab/universal.css 😆. Also, styling a <input> as a link is also pretty horrid 😢.

@Mottie
Copy link
Member

@Mottie Mottie commented on 529462d May 24, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are defined in primer: https://github.com/primer/primer/blob/master/scss/utilities/_colors.scss & https://github.com/primer/primer/blob/master/scss/utilities/_border.scss

Almost all of those definitions include !important.

@silverwind
Copy link
Member Author

@silverwind silverwind commented on 529462d May 24, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least those things make it easier for us so we don't have to style hundreds of different border classes. They appear to switch over to Primer gradually, so we probably should at some point check if we cover all classes.

@Mottie
Copy link
Member

@Mottie Mottie commented on 529462d May 24, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to get primer to work as a base, but it's missing a lot of GitHub specific definitions. So instead, I started working on a method to allow us to grab the two css files GitHub serves with each page, strip out all non-color definitions, then build a dark script from there (see Gruntfile.js).

It's still a work-in-progress, and doesn't cover everything. I'll push the work I have done so far to the "working" branch of this repo if you want to check it out. So far the resulting, non-minified file (github-darkv2.css) is a little bigger than our current "github-dark.css" file. I'm sure it'll get smaller if we use something like cssnano.

Update: added link to working branch files.

@Mottie
Copy link
Member

@Mottie Mottie commented on 529462d May 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, working branch added... it may not work out, but I thought it would be interesting to at least test out this method.

Please sign in to comment.