add packet-forward-middleware #800
Conversation
sontrinh16
requested review from
asalzmann,
sampocs and
riley-stride
and removed request for
asalzmann and
sampocs
| @@ -622,7 +644,13 @@ func NewStrideApp( | |||
| transferStack = ratelimitmodule.NewIBCMiddleware(app.RatelimitKeeper, transferStack) | |||
| transferStack = recordsmodule.NewIBCModule(app.RecordsKeeper, transferStack) | |||
| transferStack = autopilot.NewIBCModule(app.AutopilotKeeper, transferStack) | |||
|
|
|||
| transferStack = router.NewIBCMiddleware( | |||
There was a problem hiding this comment.
It looks like this will be at the top of the middleware stack, can you confirm that and update the comment above?
There was a problem hiding this comment.
ok, exactly that. I'm sorry
There was a problem hiding this comment.
Can you please update the comment above
I added some description Where can I write tests, I didn't find a place to write tests for intechaintest |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This should remain open |
| @@ -17,13 +17,17 @@ require ( | |||
| github.com/spf13/cast v1.5.0 | |||
| github.com/spf13/cobra v1.6.1 | |||
| github.com/spf13/pflag v1.0.5 | |||
| github.com/strangelove-ventures/packet-forward-middleware/v7 v7.0.0-20230523193151-73dea436e53f | |||
There was a problem hiding this comment.
@DongLieu can you bump this to the correct version? Why is it on a specific commit hash?
There was a problem hiding this comment.
Currently, i did not find the official one for sdk v0.47.2. If you want I can make a fork version.
| @@ -104,6 +106,12 @@ func (app *StrideApp) setupUpgradeHandlers() { | |||
| v9.CreateUpgradeHandler(app.mm, app.configurator, app.ClaimKeeper), | |||
| ) | |||
|
|
|||
| // v10 upgrade handler | |||
| app.UpgradeKeeper.SetUpgradeHandler( | |||
There was a problem hiding this comment.
@DongLieu this will need to go in the v12 upgrade
| @@ -622,7 +644,13 @@ func NewStrideApp( | |||
| transferStack = ratelimitmodule.NewIBCMiddleware(app.RatelimitKeeper, transferStack) | |||
| transferStack = recordsmodule.NewIBCModule(app.RecordsKeeper, transferStack) | |||
| transferStack = autopilot.NewIBCModule(app.AutopilotKeeper, transferStack) | |||
|
|
|||
| transferStack = router.NewIBCMiddleware( | |||
There was a problem hiding this comment.
Can you please update the comment above
|
ok, I will edit again |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
Brief Changelog
Author's Checklist
run all tests passed
golangci-lint run --fix