Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing vertical lines, fix link title #20

Merged
merged 1 commit into from
Apr 11, 2024
Merged

add missing vertical lines, fix link title #20

merged 1 commit into from
Apr 11, 2024

Conversation

jheison-rodriguez
Copy link
Contributor

Change description

add missing vertical lines, fix link title

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@jheison-rodriguez jheison-rodriguez added the ready_for_review PR is ready for review label Apr 11, 2024
@jheison-rodriguez jheison-rodriguez merged commit 06c4d42 into main Apr 11, 2024
8 checks passed
@jheison-rodriguez jheison-rodriguez deleted the feature/SGINT-909-fix-header-link-title branch April 11, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernandoPedraza-sg fernandoPedraza-sg fernandoPedraza-sg approved these changes

@JoseMotto-sg JoseMotto-sg Awaiting requested review from JoseMotto-sg

Assignees
No one assigned
Labels
ready_for_review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jheison-rodriguez @fernandoPedraza-sg