Course search promise rejection

[drewvolz]

Happens when the course search data for Android is loaded.

[hawkrives]

Can you give us the stack trace from the devtools? That'll have the actual file paths in it

[drewvolz]

I could not. I spent an hour trying to get RN debugger to launch but it was freezing and stalling out. My devtools would not successfully launch.

[drewvolz]

Weirdly enough, the error happens when I do not have a debugger enabled. I cannot replicate with the debugger, but I see the rejection when using as normal.

[drewvolz]

Bugsnag has this to say:

[drewvolz]

Relevant: facebook/react-native#15902

[hawkrives]

Try

// symbol polyfills
global.Symbol = require('core-js/es6/symbol');
require('core-js/fn/symbol/iterator');

// collection fn polyfills
require('core-js/fn/map');
require('core-js/fn/set');

The reason it works with a debugger is that remote debugging uses Chrome's js engine, instead of the bundled js engine.

[drewvolz]

Getting a runtime error to the effect of Incompatible receiver, Set required! which that thread is hinting at core-js being the culprit.

[hannesmcman]

So is there nothing we can do about this one besides wait?

[hawkrives]

I'll try to dig into this. Assigning to me.

[hawkrives]

Having looked at the code again, I think it's the Promise#finally:

AAO-React-Native/source/views/sis/course-search/search.js

Line 233 in f74db94

.finally(() => this.doneLoading())

Promise.prototype.finally is not yet standardized. I have now made a local branch that replaces the Promise chain here with an async function, which should have the same results.

[hawkrives]

Not fixed yet.

So yeah, we still have the Symbol.iterator problem. Easy (temporary) solution: move away from p-props.

Long term: figure out how to set Array.prototype[Symbol.iterator] so that things work.

[hannesmcman]

@hawkrives Should this be reopened?