2926 bug undo feature of multitool delete your upload file #3101
+64
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or any index change
This caused unhandled exception leading to undo when removing files to not resolve
ConnorYoh
requested review from
Frooodle,
reecebrowne,
Ludy87 and
DarioGii
as code owners
1 task
dosubot
bot
added
size:L
github-actions
bot
added
the
Front End
|
/deploypr |
|
You can still remove your uploaded files by clicking the undo button. Redo will open up the file picker but not automatically reupload the file. |
🚀 PR Test DeploymentYour PR has been deployed for testing! 🔗 Test URL: http://185.252.234.121:3101 This deployment will be automatically cleaned up when the PR is closed. |
reecebrowne
approved these changes
Mar 2, 2025
Frooodle
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please provide a summary of the changes, including:
What was changed
Added support for single page and multi page undo/redo drag and drop in multitool
removed selecting pages from undo/redo stack
Why the change was made
Drag and drop was not supported fully with undo/redo functionality
Closes #(2926)
[Checklist]
General
Documentation
UI Changes
I Will start a demo in PR so people can try the new functionality
numberedpages.pdf
Please feel free to use this PDF to aid with trying out the new functionality
Testing (if applicable)