Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Case-Insensitive Key Comparison and Path Normalization in Language Properties Check Script #3067

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Feb 26, 2025

Description of Changes

Please provide a summary of the changes, including:

  • Updated key comparison logic in update_missing_keys function to be case-insensitive by converting keys to lowercase before comparison.
  • Introduced os.path.normpath for file path normalization to improve cross-platform compatibility.
  • Replaced direct usage of file_path with file_normpath in security checks, file size validation, and duplicate key detection to ensure consistent path handling.

These changes improve the robustness and maintainability of the script, ensuring more accurate language property checks while enhancing security validation.


Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Feb 26, 2025
@Ludy87 Ludy87 linked an issue Feb 26, 2025 that may be closed by this pull request
1 task
@Frooodle Frooodle merged commit c9c8378 into Stirling-Tools:main Feb 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Github size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Improved verification of translations and their keys
2 participants