-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix displayed identical fonts in sign PDF #2751
Fix displayed identical fonts in sign PDF #2751
Conversation
@omar-ahmed42 this was done in older version, but it has issues with firefox and other browsers, does your above changes work on FF? |
@Frooodle Yes, it works now in Firefox but the implementation is different to some degree as I had to hide the original Also, the screenshots above are all from Firefox. Notes:
Useful quotes from MDN:
Useful references: |
Do we want to adjust the text displayed with the typed text? Or maintain font name as the text @reecebrowne @omar-ahmed42 Thoughts? |
@Frooodle Personally, I think keeping font names would be better than replacing it with the typed text, why? It makes it easier for the user to memorize and remember the font family used for future use (especially if we had to reorder the font families or if we added more font families). At first, I thought of displaying a signature preview in a div/container that appears next to the option on hover but I ran into a problem which is "how practical would this solution be for mobile/phone UI?" then I thought of adding a preview field above the font selection to preview the currently selected or hovered over option/font but I can't think of an eye-pleasing design at the moment. Let me know if you have any ideas |
I agree with all of that! Makes sense |
Description of Changes
Changes:
<select>
element (display: none;
) and wrap it with a<div>
and then create a custom selection menu using<div>
s and CSS to achieve the required results due to the limitations of<select>
and<option>
while still preserving the hidden<select>
for form submission.Why was the change made?
1.
is of higher priority.UI Changes:
Dark Mode:
Before:

After:

Light Mode:
Before:

After:

Note:
sign.js
are between the lines 95-228, as it seems the file was auto-formatted affecting whitespaces and single_quotes/double_quotes.Useful quotes from MDN:
Useful references:
Closes #1575
Checklist
General
Documentation
UI Changes (if applicable)
Testing (if applicable)